-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the default classes immutable and mark mutable classes explictly #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes to EDM4hep itself amounts to only very few fixes with the current version: https://github.com/tmadlener/EDM4hep/compare/master...tmadlener:mutable-podio-classes?expand=1 |
71b5a04
to
6b34968
Compare
A more realistic diff for usage where also mutable classes are actually used from k4SimDelphes: |
6b34968
to
30ce533
Compare
abde130
to
808ea39
Compare
08110fb
to
e4efbcb
Compare
and remove ConstObject templates
- Make ExtraCode -> MutableExtraCode - Make ConstExtraCode -> ExtraCode - Remove ConstExtraCode
e4efbcb
to
b22875d
Compare
This was referenced Dec 3, 2021
This was referenced Dec 7, 2021
This was referenced Dec 9, 2021
Closed
vvolkl
added a commit
to vvolkl/k4RecCalorimeter
that referenced
this pull request
Feb 2, 2022
- Replace some dedicated types with `auto` and rename others (Cluster -> MutableCluster, ConstCluster -> Cluster) to adapt to the new naming scheme introduced in AIDASoft/podio#205. - The necessary changes in EDM4hep: key4hep/EDM4hep#132 would break this otherwise. Due to the explict use of Mutable* (in attachCells) this now requires a new version of edm4hep.
vvolkl
added a commit
to vvolkl/k4SimGeant4
that referenced
this pull request
Feb 2, 2022
- Replace some dedicated types with and rename others (Cluster -> MutableCluster, ConstCluster -> Cluster) to adapt to the new naming scheme introduced in AIDASoft/podio#205.
vvolkl
added a commit
to vvolkl/k4Gen
that referenced
this pull request
Feb 2, 2022
- Replace some dedicated types with and rename others (Cluster -> MutableCluster, ConstCluster -> Cluster) to adapt to the new naming scheme introduced in AIDASoft/podio#205.
vvolkl
added a commit
to vvolkl/CEPCSW
that referenced
this pull request
Feb 2, 2022
- Replace some dedicated types with and rename others (Cluster -> MutableCluster, ConstCluster -> Cluster) to adapt to the new naming scheme introduced in AIDASoft/podio#205.
vvolkl
added a commit
to vvolkl/dual-readout
that referenced
this pull request
Feb 2, 2022
- Replace some dedicated types with and rename others (Cluster -> MutableCluster, ConstCluster -> Cluster) to adapt to the new naming scheme introduced in AIDASoft/podio#205.
SanghyunKo
pushed a commit
to HEP-FCC/dual-readout
that referenced
this pull request
Feb 3, 2022
- Replace some dedicated types with and rename others (Cluster -> MutableCluster, ConstCluster -> Cluster) to adapt to the new naming scheme introduced in AIDASoft/podio#205.
vvolkl
added a commit
to HEP-FCC/k4RecCalorimeter
that referenced
this pull request
Feb 3, 2022
* Adapt to new podio generated class names - Replace some dedicated types with `auto` and rename others (Cluster -> MutableCluster, ConstCluster -> Cluster) to adapt to the new naming scheme introduced in AIDASoft/podio#205. - The necessary changes in EDM4hep: key4hep/EDM4hep#132 would break this otherwise. Due to the explict use of Mutable* (in attachCells) this now requires a new version of edm4hep. * Update RecCalorimeter/src/components/CorrectECalBarrelSliWinCluster.cpp Co-authored-by: Brieuc Francois <brieuc.francois@cern.ch> Co-authored-by: Brieuc Francois <brieuc.francois@cern.ch>
vvolkl
added a commit
to HEP-FCC/k4Gen
that referenced
this pull request
Feb 4, 2022
- Replace some dedicated types with and rename others (Cluster -> MutableCluster, ConstCluster -> Cluster) to adapt to the new naming scheme introduced in AIDASoft/podio#205.
vvolkl
added a commit
to HEP-FCC/k4SimGeant4
that referenced
this pull request
Feb 4, 2022
- Replace some dedicated types with and rename others (Cluster -> MutableCluster, ConstCluster -> Cluster) to adapt to the new naming scheme introduced in AIDASoft/podio#205.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
Hit
andMutableHit
). See a brief discussion in Proposal to make the Const classes default and explicitly mark the mutable ones as mutable #204 for more details on the reasons for this breaking change.create
functionality, and will only give access to the default (immutable) objects when they areconst
(e.g. when they are read from file).ENDRELEASENOTES
This is a first shot to implement the proposal #204. As a first draft implementation it prepends
Mutable
to all class names that are mutable and removes theConst
prefix from all immutable ones.Built on top of #143!
ConstExtraCode
andExtraCode
?