Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add basic I/O tests for datamodel extensions #361

Merged
merged 5 commits into from
Jan 16, 2023
Merged

Add basic I/O tests for datamodel extensions #361

merged 5 commits into from
Jan 16, 2023

Conversation

tmadlener
Copy link
Collaborator

BEGINRELEASENOTES

ENDRELEASENOTES

@tmadlener tmadlener mentioned this pull request Dec 22, 2022
Merged
13 tasks
@tmadlener tmadlener force-pushed the extension-model-io-tests branch from 854a41c to 1bdd461 Compare December 23, 2022 09:32
jmcarcell
jmcarcell approved these changes Jan 9, 2023
View reviewed changes
Copy link
Member

@jmcarcell jmcarcell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran the tests and all looks fine. I found a couple of typos in the code. Can you please add tests/extension_model to the .gitignore?

python/podio/test_Frame.py Outdated Show resolved Hide resolved
python/podio/test_Frame.py Outdated Show resolved Hide resolved
@tmadlener tmadlener force-pushed the extension-model-io-tests branch from 1bdd461 to dc4a0f6 Compare January 10, 2023 12:25
@tmadlener tmadlener force-pushed the extension-model-io-tests branch from dc4a0f6 to b9defae Compare January 10, 2023 12:40
vvolkl
vvolkl reviewed Jan 10, 2023
View reviewed changes
python/podio/test_Frame.py Outdated Show resolved Hide resolved
@tmadlener @vvolkl
Fix typo
8a03de5 
Co-authored-by: Valentin Volkl <valentin.volkl@cern.ch>
@tmadlener tmadlener merged commit f6535cb into AIDASoft:master Jan 16, 2023
@tmadlener tmadlener deleted the extension-model-io-tests branch January 16, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vvolkl vvolkl vvolkl left review comments

@jmcarcell jmcarcell jmcarcell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extension datamodel functionality does not yet have I/O tests
3 participants
@tmadlener @vvolkl @jmcarcell