Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the TTree based ROOT backend store the GenericParameters the same way as the RNTuple based one #615

Merged
merged 17 commits into from
Jun 11, 2024
Merged

Make the TTree based ROOT backend store the GenericParameters the same way as the RNTuple based one #615

merged 17 commits into from
Jun 11, 2024

Conversation

tmadlener
Copy link
Collaborator

@tmadlener tmadlener commented Jun 5, 2024 •
edited
Loading

@tmadlener tmadlener changed the title Make the TTree based ROOT backend store the Make the TTree based ROOT backend store the GenericParameters the same way as the RNTuple based one Jun 5, 2024
@tmadlener tmadlener changed the title Make the TTree based ROOT backend store the GenericParameters the same way as the RNTuple based one [WIP] Make the TTree based ROOT backend store the GenericParameters the same way as the RNTuple based one Jun 5, 2024
@tmadlener tmadlener force-pushed the uniform-generic-param-storage branch from f88e3a1 to a2b022b Compare June 6, 2024 09:04
@tmadlener tmadlener mentioned this pull request Jun 11, 2024
Merged
@tmadlener tmadlener force-pushed the uniform-generic-param-storage branch from a2b022b to 40b7634 Compare June 11, 2024 09:24
tmadlener added 16 commits June 11, 2024 14:21
@tmadlener
Refactor root utilities and reduce code duplication
024c0b1 
- Lift common type defs into one header to not redefine them
- Keep all root related utilitie classes in one header
@tmadlener
Rename CollectionInfo to CategoryInfo to better convey intention
2af5336
@tmadlener
Remove unnecessary member variables
283be1d
@tmadlener
Add functionality to get all values for a type to GenericParameters
3450586
@tmadlener
Move some global state into category state
80d267a
@tmadlener
Avoid unnecessary copy
a882b51
@tmadlener
Fix include guards to conform to style guide
10d1b3b
@tmadlener
Make sure to take lock long enough
c4b48d4
@tmadlener
Switch to tuple for consistency
8fd6811
@tmadlener
Remove obsolete reset
ba9f090
@tmadlener
Make the ROOTWriter write split GenericParameters
d1642aa
@tmadlener
Make the ROOTReader read the files again
39e04bf
@tmadlener
Add tests to make sure that v00-99 files stay readable
9a6ea9e
@tmadlener
Make older compilers happy with in place construction
7184f7d
@tmadlener
Make sure to only run SIO legacy tests when input data is available
866710d
@tmadlener
Make tests work by hiding forward declaration from CLING
7398cf3
@tmadlener tmadlener force-pushed the uniform-generic-param-storage branch from 771d995 to 7398cf3 Compare June 11, 2024 12:27
hegner
hegner approved these changes Jun 11, 2024
View reviewed changes
include/podio/GenericParameters.h
@@ -30,6 +31,10 @@ class RNTupleWriter;

namespace podio {

#if !defined(__CLING__)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one line of documentation why that is the case - if possible to explain

@hegner hegner merged commit 50bfe41 into AIDASoft:master Jun 11, 2024
18 checks passed
@hegner hegner changed the title [WIP] Make the TTree based ROOT backend store the GenericParameters the same way as the RNTuple based one Make the TTree based ROOT backend store the GenericParameters the same way as the RNTuple based one Jun 11, 2024
@hegner hegner mentioned this pull request Jun 11, 2024
Merged
@tmadlener tmadlener mentioned this pull request Jun 11, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hegner hegner hegner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GenericParameters should be stored the same way for TTree and RNTuple backends
2 participants
@tmadlener @hegner