-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a deprecation warning when building with C++17 #700
Conversation
Should we also set the default standard to 20 then, and not print the warning if the user doesn't do anything? (cannot comment on the line directly) |
Yes, definitely. |
Added, initially I thought about leaving all the changes to #698 (the warning only doesn't change anything compared to the default changing now). |
The edit: they are most likely related to several changes to RNTuple for RC3. |
b843cc3
to
d07f891
Compare
* Add a deprecation warning when building with C++17 * Specify a version when support for C++17 will be removed * Set the default to C++20 --------- Co-authored-by: jmcarcell <jmcarcell@users.noreply.github.com>
BEGINRELEASENOTES
ENDRELEASENOTES