Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a deprecation warning when building with C++17 #700

Merged
merged 3 commits into from
Nov 8, 2024

Conversation

jmcarcell
Copy link
Member

BEGINRELEASENOTES

ENDRELEASENOTES

CMakeLists.txt Outdated Show resolved Hide resolved
@andresailer
Copy link
Member

Should we also set the default standard to 20 then, and not print the warning if the user doesn't do anything?

(cannot comment on the line directly)
https://github.com/AIDASoft/podio/pull/700/files#diff-1e7de1ae2d059d21e1dd75d5812d5a34b0222cef273b7c3a2af62eb747f9d20aR37

@tmadlener
Copy link
Collaborator

Should we also set the default standard to 20 then, and not print the warning if the user doesn't do anything?

Yes, definitely.

@jmcarcell
Copy link
Member Author

jmcarcell commented Nov 5, 2024

Added, initially I thought about leaving all the changes to #698 (the warning only doesn't change anything compared to the default changing now).

@tmadlener
Copy link
Collaborator

tmadlener commented Nov 5, 2024

The dev3 based workflows are failing for several PRs and I think is unrelated to the changes in any of those. From what I can tell from just looking at the outputs, it looks like we no longer recognize whether a file has a TTree or an RNTuple inside and it then instantiates the wrong reader in the interface:

https://github.com/AIDASoft/podio/actions/runs/11681697887/job/32527272599?pr=700#step:4:855

edit: they are most likely related to several changes to RNTuple for RC3.

@tmadlener tmadlener merged commit b5cddb7 into AIDASoft:master Nov 8, 2024
18 checks passed
jmcarcell added a commit to jmcarcell/podio that referenced this pull request Nov 18, 2024
* Add a deprecation warning when building with C++17

* Specify a version when support for C++17 will be removed

* Set the default to C++20

---------

Co-authored-by: jmcarcell <jmcarcell@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants