added prefix verb and filter #39
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @ruslanmustafin , thanks for your contribution. Before merging. Would you care adding a test? @AiVerisimilitude any remarks? |
| def filter_msg(self, msg): | ||
| (topic, data, t) = msg | ||
|
|
||
| return (self._add_prefix(topic), data, t) |
| return f"{self._prefix}{topic_name}" | ||
|
|
||
| def filter_topic(self, topic_metadata): | ||
| # if topic_metadata.name == self._topic: |
|
|
||
| def add_arguments(self, parser): | ||
| parser.add_argument('-p', '--prefix', help='prefix to add') | ||
| # parser.add_argument('--name', required=True, help='new name to set') |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prefix allows to add a fixed pre-defined prefix to all topics inside a bag. Could be useful in case there are two bag files with identical topic names that need to be merged with
ros2 bag convert