Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add baseline LR advisor #29

Merged
merged 6 commits into from
Feb 5, 2025
Merged

Add baseline LR advisor #29

merged 6 commits into from
Feb 5, 2025

Conversation

aphedges
Copy link
Contributor

@aphedges aphedges commented Feb 3, 2025

This PR contains the code changes from #19 and 53ba04a, which I then cleaned up and rebased against the more general changes I have already merged to main. The bot itself was good, but I needed to modify the code so we can merge it without causing problems for any other bots.

The code changes to these specific files should be pretty minimal, but they should still be tested and looked over to make sure there weren't any regressions.

aphedges and others added 6 commits February 3, 2025 16:38
Generated automatically by
`pip install -e .[baseline-lr] && make lock`
Co-authored-by: Alex Hedges <git@alexhedges.dev>
Co-authored-by: Alexander Jephtha <ajep3697@uni.sydney.edu.au>
Without this change, importing any bot will cause a crash unless the
optional dependency is installed.
To make builds easier, I decided to store the model weights directly in
an OCI image.

First, I downloaded the model weights and unzipped them into a directory
named `lr_model/`.

Then, I created a `Dockerfile` in the same directory that contained
`lr_model/`:

```dockerfile
FROM scratch
COPY lr_model/ /lr_model/
```

Finally, I ran the following commands to create and upload the OCI image
containing only the model weights directory:

```shell
docker build --platform linux/amd64 --tag ghcr.io/allan-dip/chiron-utils:baseline-lr-model-2025-01-14 .
docker push ghcr.io/allan-dip/chiron-utils:baseline-lr-model-2025-01-14
```
Co-authored-by: Alex Hedges <git@alexhedges.dev>
@aphedges aphedges requested a review from gale2307 February 3, 2025 21:57
@aphedges aphedges self-assigned this Feb 3, 2025
Copy link
Collaborator

@gale2307 gale2307 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with lr_20250114.zip and works great! I'll merge the changes

@gale2307 gale2307 merged commit e095a92 into main Feb 5, 2025
2 checks passed
@gale2307 gale2307 deleted the add-baseline-lr-advisor branch February 5, 2025 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants