Publish from release #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
January 18, 2024 11:00
Still require commits to be tagged.
Will be enforced via branch protection.
Onur4229
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed, we want to change our CD pipeline.
Currently we publish all tagged commits on
master. Untagged commits on master lead to a worklflow failure.This PR will update the behavior: We publish all commits on the
releasebranch. We disallow direct commits toreleaseand instead require those to be made as PRs (from master). We further enforce all such merges to have a version tag (I can enable such branch protection after this PR was merged).I also deleted the workflow for automatic deployment onto TestPyPI as there is no such usage intended.