-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove go-pkg template #80
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed the `go-pkg` template from the `.github/workflows/flake-language.yml` file. - Updated the README to remove the reference to `go-pkg` for building legacy Go apps.
Updated the URLs for home-manager and nixpkgs in the flake.nix files for darwin, nixos-desktop, and nixos-minimal templates to point to the release-24.11 versions. This ensures the templates use the latest versions of these dependencies.
The sound.enable setting has been removed as it is redundant with the current configuration. Pulseaudio is disabled and Pipewire is being used for sound management.
Updated the home-manager and nixpkgs URLs in the flake.nix file to point to the release-25.05 versions. This ensures compatibility with the latest features and improvements in the new release.
Updated the home-manager URL to point to the latest version instead of a specific release. Changed the nixpkgs URL to use the nixos-unstable branch for more up-to-date packages.
- Updated `system.stateVersion` and `home.stateVersion` across various modules to "24.11". - Ensures consistency in versioning for system and home-manager configurations. - Affects darwin, nixos-desktop, and nixos-minimal templates.
- Added `optimise.automatic = true;` to the Nix configuration in darwin, nixos-desktop, and nixos-minimal templates. - Removed `auto-optimise-store = true;` from the Nix settings as it is now replaced by the new automatic optimization setting.
The nix-daemon service enablement has been removed from the darwin.nix configuration. This change simplifies the module configuration by eliminating the explicit setting of services.nix-daemon.enable to true.
muandane
approved these changes
Feb 12, 2025
Sironheart
reviewed
Feb 12, 2025
Sironheart
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
buildGoPackage
so we should remove the template.