-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ci): add gha workflow to update the flake lockfile #98
Conversation
cameronraysmith
commented
Feb 23, 2025
- reveal root cause of
- flake-parts is an undeclared input to the top-level and all language template flakes #96 (comment)
- add gha workflow to submit a PR to update the flake lockfile
- PR will allow other workflows to check that the flake inputs from the lockfile can be safely updated without breaking functionality
b02c720
to
b58dd84
Compare
You can see the (currently) expected CI failure here |
Signed-off-by: Cameron Smith <cameron.ray.smith@gmail.com>
b58dd84
to
642be4c
Compare
642be4c
to
8dde656
Compare
I primarily did this to check that the lockfile was not previously updatable without access to flake registries. In any case, rebasing this branch after #97 and #100, this workflow now succeeds as expected and successfully submitted this PR on my fork to merge the updated lockfile https://github.com/cameronraysmith/kickstart.nix/pull/4/files The force-push following this note will remove the actions push targeting my PR branch, which you wouldn't want to retain in the upstream. It will also have workfow dispatch enabled to support manually triggering the lockfile update. |
- not desirable to run this on push outside of testing the workflow Signed-off-by: Cameron Smith <cameron.ray.smith@gmail.com>
806e860
to
95166f3
Compare
Hiya, It needs some tweaking, but we'd rather do this via Renovate like we do for our other projects. Current config is here: I appreciate the PR, and I hope this doesn't discourage you from further contributions to Kickstart.nix, but I'm going to decline this one for now. If you want to take a look at our Renovate setup and find improvements there, feel free though! |
Renovate is a reasonable way to manage the lockfile, but do you think it's working since you've never received/merged a PR over the course of 9 months Moreover, you'd have to pass a custom command to address #98 (comment). But I would certainly recommend verifying renovate is working as expected over adding another github actions workflow to maintain. As I said, I only added it to test #97 and #100 on my fork and illustrate that It may be that the difference between #98 (comment) and #98 (comment) will allow renovate to successfully update the |
Originally posted by @hbjydev in #98 (comment)
renovatebot/renovate#29721 This is one of the reasons most nix repos in the wild use both renovate and a separate gha workflow to update the flake lockfile, but should become irrelevant if renovate eventually resolves the problems like 29721 and possibly others that are related to unreliable updates of flake lockfiles. |