No flattening of timepoint specific overrides in jax #2641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2641 +/- ##
===========================================
+ Coverage 77.14% 77.16% +0.01%
===========================================
Files 332 332
Lines 23021 23137 +116
Branches 1478 1478
===========================================
+ Hits 17760 17854 +94
- Misses 5250 5272 +22
Partials 11 11
Flags with carried forward coverage won't be shown. Click here to find out more.
|
dweindl
approved these changes
Feb 5, 2025
| pysb_model, name, sigmas | ||
| # note that this is a bit iffy since we are potentially using the same symbolic identifier in expressions (w) | ||
| # and observables (y). This is not a problem as there currently are no model functions that use both. If this | ||
| # changes, I would expect symbol redefinition warnings in CPP models and overwriting in JAX models, but as both |
There was a problem hiding this comment.
I think these warnings are easily overlooked. Maybe we should turn them into errors. But this will break the import of at least one benchmark collection model that has something named NULL. Fine for now.
Co-authored-by: Daniel Weindl <dweindl@users.noreply.github.com>
…into jax_no_flattening
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.