Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add publishing pipeline #32

Merged
merged 1 commit into from
Jul 21, 2024

Conversation

SCiarella
Copy link
Contributor

@SCiarella SCiarella commented Jun 28, 2024

This pull request addresses #27 by implementing a publishing pipeline in .github/workflow/publish.yaml.
The action is triggered every time a new version of lie_learn gets published and it automatically updates the entry on pypi.
In this way, downstream libraries (like escnn) can use lie_learn much more easily.

To fully close #27 it is required to:

  1. enable trusted publishing
  2. either publish a new release of lie_learn or manually trigger publish.yaml via:
    Actions->'Build and Publish'->Run Workflow

Due to the end of life the current process only supports python>=3.9, but it is possible to include older versions to this workflow if needed.

Finally, notice that there are some issues with the recent release of Numpy 2.0.0 (also discussed in #30), so we have enforced numpy<2 in the dependency.

Co-Authored-By: Victor Azizi <victor@lipsum.eu>
@tscohen
Copy link
Collaborator

tscohen commented Jul 21, 2024

LGTM. @mariogeiger and @bkmi has are maintaining the PyPi package, so only they can enable trusted publishing. I'll send them a message as well.

@tscohen tscohen merged commit 2b562aa into AMLab-Amsterdam:master Jul 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pip install error with python 3.11
2 participants