Side navigation #467
Merged
Side navigation #467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Elkrival
force-pushed
the
side-navigation
branch
from
f8d1de4 to
f0b3deb
Compare
|
@Elkrival CI failure is an easy fix. In package.json set: "jest": {
"setupFilesAfterEnv": [
"<rootDir>/jest-setup.js"
],
"moduleNameMapper": {
"\\.(css|less|scss|sass)$": "identity-obj-proxy"
}
},and in import '@testing-library/jest-dom'Then delete the jest-dom import from |
* updated jest preferences * Fixed test
Elkrival
merged commit 319eb8c
into
428-update-material-ui-version-to-the-latest-stable-version
3 checks passed
Elkrival
added a commit
that referenced
this pull request
Nov 8, 2023
* Sidebar * Added testing library * Refactored Sidebar components and added tests * Added color theme to material ui * Updated Sidebar component into smaller pieces * Added measurements stylings * Cleaned up tests * Renamed tests * Await * Added await syntax * Var * Renamed var * Syntax * js dom set up * updated jest preferences * Fixed test
Elkrival
added a commit
that referenced
this pull request
Nov 8, 2023
* Sidebar * Added testing library * Refactored Sidebar components and added tests * Added color theme to material ui * Updated Sidebar component into smaller pieces * Added measurements stylings * Cleaned up tests * Renamed tests * Await * Added await syntax * Var * Renamed var * Syntax * js dom set up * updated jest preferences * Fixed test
Elkrival
added a commit
that referenced
this pull request
Nov 8, 2023
* Sidebar * Added testing library * Refactored Sidebar components and added tests * Added color theme to material ui * Updated Sidebar component into smaller pieces * Added measurements stylings * Cleaned up tests * Renamed tests * Await * Added await syntax * Var * Renamed var * Syntax * js dom set up * updated jest preferences * Fixed test
Elkrival
added a commit
that referenced
this pull request
Nov 8, 2023
* Login Page * Added Login Page UI designs 3Fixed Test
Elkrival
added a commit
that referenced
this pull request
Nov 8, 2023
Elkrival
added a commit
that referenced
this pull request
Nov 27, 2023
Elkrival
added a commit
that referenced
this pull request
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #436
This pr adds the stylings for the SideNavigation component.
This sets up the theme with the colors used in the figma designs.
It adds rendering tests and testing library set up.