Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not read RPMS CSV files within 7:55-8:10 pm #119

Merged
merged 1 commit into from
May 31, 2023

Conversation

tashrifbillah
Copy link

They are exported by RPMS and modified by Tashrif's programs during this window

they are exported by RPMS and modified by Tashrif's programs during this window
@tashrifbillah tashrifbillah requested a review from kcho May 27, 2023 21:15
Copy link
Member

@kcho kcho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The delay added in this PR is required for Tashrif's pipeline to work properly. Also this update keeps the lochness pipeline working unaffected for the time window outside 19~20. Looks good to me.

@kcho kcho merged commit b602602 into kcho/prescient May 31, 2023
@tashrifbillah
Copy link
Author

Hi @kcho , RPMS whimsically changed the export time to 7 pm. So I need to change the hibernation period too. This time, I shall probably do it via environment variables so we don't have to pull request in future. Just a heads up that another PR is coming. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants