Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix.: Make Zoomver.tag case insenstitve and relax recodring.conf matching #135

Merged
merged 1 commit into from
Feb 13, 2024

Conversation

dheshanm
Copy link
Member

Previous PR #134 did not ignore zoomver.tag (compared to Zoomver.tag). This PR addresses that by checking for just ver.tag and ignoring it.

Similarly, relax matching recording.conf by checking for endswith rather than exact match.

@dheshanm dheshanm requested a review from kcho February 12, 2024 15:17
@dheshanm dheshanm self-assigned this Feb 12, 2024
Copy link
Member

@kcho kcho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@dheshanm dheshanm merged commit 6534cb6 into kcho/prescient Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants