This repository has been archived by the owner on Apr 2, 2024. It is now read-only.
Don't attempt to trim keys for presets #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At some point this code was doing both key and account creation, and returning a combined status object. But the refactoring was incomplete and has led to HAS_OLD_KEYS being set in error. As the account creation is now handled entirely separately just put this back to what was there originally.
The API has been completely reworked and is no longer either Java-compatible or a monad.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The operator was attempting to run
trim_keyson Preset keys. This was failing because the Secrets were not writable by the operator.The root cause was a bug introduced during refactoring of the account creation code.
Also forbid optional.py v2.0, newly uploaded on 13 March and with a different and useless API.