Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix initial He4 mass fraction in Detonation #2806

Merged
merged 2 commits into from
Mar 27, 2024
Merged

Fix initial He4 mass fraction in Detonation #2806

merged 2 commits into from
Mar 27, 2024

Conversation

yut23
Copy link
Collaborator

@yut23 yut23 commented Mar 27, 2024 •
edited
Loading

PR summary

There were two separate issues with the helium mass fraction calculation:

  • If any of cfrac, nfrac, or ofrac were zero, the corresponding mass fractions would be clamped to smallx, but the helium mass fraction didn't account for this.
  • The number of remaining species was one too high, as it should also exclude He4.

PR motivation

PR checklist

  • test suite needs to be run on this PR
  • this PR will change answers in the test suite to more than roundoff level
  • all newly-added functions have docstrings as per the coding conventions
  • the CHANGES file has been updated, if appropriate
  • if appropriate, this change is described in the docs

@zingale zingale merged commit 21c2bc5 into AMReX-Astro:development Mar 27, 2024
23 checks passed
@yut23 yut23 deleted the fix-detonation-initial-composition branch March 27, 2024 21:11
@yut23 yut23 mentioned this pull request Mar 29, 2024
Open
@yut23 yut23 mentioned this pull request Jul 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zingale zingale zingale approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yut23 @zingale