Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move the HLL solvers into their own header #2887

Merged
merged 3 commits into from
Jun 27, 2024
Merged

move the HLL solvers into their own header #2887

merged 3 commits into from
Jun 27, 2024

Conversation

zingale
Copy link
Member

@zingale zingale commented Jun 25, 2024

PR summary

PR motivation

PR checklist

  • test suite needs to be run on this PR
  • this PR will change answers in the test suite to more than roundoff level
  • all newly-added functions have docstrings as per the coding conventions
  • the CHANGES file has been updated, if appropriate
  • if appropriate, this change is described in the docs

@zingale zingale mentioned this pull request Jun 25, 2024
Merged
5 tasks
@maximumcats
Copy link
Member

Could be a good opportunity to put these into a namespace.

@zingale
Copy link
Member Author

zingale commented Jun 25, 2024

done

@zingale zingale merged commit 5b08683 into AMReX-Astro:development Jun 27, 2024
25 checks passed
@zingale zingale deleted the riemann_reorg branch June 27, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khanakbhargava khanakbhargava khanakbhargava approved these changes

Assignees
No one assigned
Labels
clean-up hydro
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zingale @maximumcats @khanakbhargava