Support complete elliptic integrals of 1st and 2nd type in Parser #3225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aveksler1 I think you might need to add GPU paths here as well. At least CUDA has a lot of special math functions, so you could check if they have what you need. An example of bessel functions we added earlier is in ECP-WarpX/WarpX#1854 |
|
The CIs failed because we treat warnings as errors. Those warnings seem to come from Bison changing the integer type in various places from int to size_t. We need to suppress those warnings. |
…ed documentation.
|
I added a separate GPU path and have suppressed the sign comparison warnings. |
|
@aveksler1 Could you merge development into this so that the Intel CI can pass? |
WeiqunZhang
approved these changes
Apr 6, 2023
guj
pushed a commit
to guj/amrex
that referenced
this pull request
Jul 13, 2023
…ReX-Codes#3225) We want to use complete elliptic integrals from `cmath`, `comp_ellint_1` and `comp_ellint_2` in the parser in order to make it easier to load in magnetic fields from coils in WarpX. I added these to the parser, and tested against the same functions in scipy - the results match. Since clang does not support special functions in C++17 (https://en.cppreference.com/w/cpp/compiler_support/17#C.2B.2B17_library_features) I implemented it for GCC compilers only, following the structure of how `jn` is implemented in the parser. Co-authored-by: Avigdor Veksler <aveksler@TAE7750-MLAP.tae.trialphaenergy.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We want to use complete elliptic integrals from
cmath,comp_ellint_1andcomp_ellint_2in the parser in order to make it easier to load in magnetic fields from coils in WarpX. I added these to the parser, and tested against the same functions in scipy - the results match.Since clang does not support special functions in C++17 (https://en.cppreference.com/w/cpp/compiler_support/17#C.2B.2B17_library_features) I implemented it for GCC compilers only, following the structure of how
jnis implemented in the parser.Additional background
Checklist
The proposed changes: