Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SoA: Public Getter for Names #4187

Merged
merged 3 commits into from
Oct 10, 2024
Merged

Conversation

ax3l
Copy link
Member

@ax3l ax3l commented Oct 9, 2024

Summary

Expose the names to public member functions.

Additional background

Needed for Python bindings. Follow-up to #4163

Checklist

The proposed changes:

  • fix a bug or incorrect behavior in AMReX
  • add new capabilities to AMReX
  • changes answers in the test suite to more than roundoff level
  • are likely to significantly affect the results of downstream AMReX users
  • include documentation in the code and/or rst files, if appropriate

@ax3l ax3l requested a review from atmyers October 9, 2024 22:58
Expose the names to public member functions.
@ax3l ax3l requested a review from WeiqunZhang October 10, 2024 06:41
@ax3l
Copy link
Member Author

ax3l commented Oct 10, 2024

Let me know what you prefer.

In fact in Python bindings I prefer the alternative of returning an empty list over having to handle an exception.

@atmyers atmyers merged commit fcc5bd2 into AMReX-Codes:development Oct 10, 2024
59 checks passed
@ax3l ax3l deleted the soa-name-public branch October 10, 2024 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants