EBData: New class containing Array4's for all EB data #4238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WeiqunZhang
force-pushed
the
eb_data
branch
3 times, most recently
from
c759d7d to
7284587
Compare
This can make the code cleaner because we can get access to all available EB data in one object. This also reduces many GPU kernels' register pressure because the GPU device lambdas are much smaller without the need to capture multiple Array4's. For example, the 3D EBABecLap's gsrb kernel's number of registers reduces from 198 to 130. Add a new function that returns a random point on EB for WarpX.
|
Needed by ECP-WarpX/WarpX#5493 |
atmyers
approved these changes
Dec 6, 2024
WeiqunZhang
added a commit
to WeiqunZhang/amrex
that referenced
this pull request
Dec 9, 2024
WeiqunZhang
added a commit
that referenced
this pull request
Dec 9, 2024
WeiqunZhang
added a commit
to WeiqunZhang/amrex
that referenced
this pull request
Dec 21, 2024
This is a new function introduced in AMReX-Codes#4238.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can make the code cleaner because we can get access to all available EB data in one object. This also reduces many GPU kernels' register pressure because the GPU device lambdas are much smaller without the need to capture multiple Array4's. For example, the 3D EBABecLap's gsrb kernel's number of registers reduces from 198 to 130.
Add a new function that returns a random point on EB for WarpX.