Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2978.
Summary
To understand what I'm trying to fix here, first note:
amrex/Tools/CMake/AMReXFlagsTargets.cmake
Lines 71 to 95 in b3f6738
Then, with Intel's classic compilers, configure AMReX with
-DCMAKE_BUILD_TYPE=Debug
and note the C++ flags listed under "AMReX configuration summary", before and after the changes suggested here. The gist isIntel
as a compiler id was matchingIntelLLVM
(andClang
was also matchingAppleClang
though the flags in that case are the same, so it's harder to tell).EDIT: this actually only affects what's printed in the summary, the flags that are actually used are already correct!
The proposed changes: