Windows #947
Merged
Windows #947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If you like to cherry-pick a remote CI build, I drafted a Windows C++17 build with a recent MSVC in ax3l@ef417d3 :) |
|
Great! I will. |
GH Action image `windows-latest` currently provides a Visual Studio 16 2019.
|
here is another one for commonly needed MSVC flags: ax3l@d60a8d8 |
- /bigobj: basically anything modern - /Za: and or keywords
ax3l
reviewed
May 30, 2020
|
This is ready for review. |
ax3l
reviewed
Jun 1, 2020
ax3l
approved these changes
Jun 2, 2020
|
I have run CPU and GPU regression testing using several codes. And beside the CI, I have tested PGI, Cray, Intel, and IBM compilers. |
5 tasks
WeiqunZhang
pushed a commit
that referenced
this pull request
Dec 3, 2020
## Summary Add missing includes to `AMReX_Extension.H`, which pulls the `<iso646.h>` include on Windows for support for `and`/`or`. ## Additional background Seen with Clang 11.0.0 on x64 Windows with Visual Studio 2017 on conda-forge during a WarpX build. See also #947 ## Checklist The proposed changes: - [x] fix a bug or incorrect behavior in AMReX - [ ] add new capabilities to AMReX - [ ] changes answers in the test suite to more than roundoff level - [ ] are likely to significantly affect the results of downstream AMReX users - [ ] are described in the proposed changes to the AMReX documentation, if appropriate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If it's Windows, use C++17 for files system operations, and avoid posix functions.
Avoid gcc extension that allows embedded prepressor directive in function macro.
Get around some MSVC template argument deduction issues.
Rename amrex::USleep to amrex:Sleep and use C++ thread for sleep. The reason for renaming is it would be very confusing that
usleepinunistdsleeps for given microseconds whereasamrex::USleepsleep for given seconds.Windows CI