Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub cache and ccache #188

Merged
merged 1 commit into from
Sep 11, 2023
Merged

GitHub cache and ccache #188

merged 1 commit into from
Sep 11, 2023

Conversation

WeiqunZhang
Copy link
Member

@WeiqunZhang WeiqunZhang commented Sep 7, 2023

Use ccache in CIs. Set up GitHub Cache for storing the ccache data.

TODO:

  • Ccache does not work on Windows. Maybe we need to provide hints to cmake CI: Windows Clang-Cl w/ CCache #190
  • Ubuntu / GNU@7.5 has 60% cache miss rate for unknown reasons. The reason seems to be the cache size was too small.
  • The CleanUpCache workflow does not work. It is supposed to triggered by the the completion of "👑 CI". But either the space (between the crown and the word CI) or the emoji is causing issues. The reason is this PR has not been merged yet. So the default branch does not have the workflow. (It would be a security issue if it updates cache according to a PR's instruction.)
  • Does CleanUpCachePostPR work? No reason it will not.
  • CodeQL

@WeiqunZhang
Copy link
Member Author

I think everything except Windows works now as expected.

@WeiqunZhang WeiqunZhang requested a review from ax3l September 7, 2023 17:25
@ax3l ax3l self-assigned this Sep 7, 2023
@ax3l
Copy link
Member

ax3l commented Sep 7, 2023

The reason that CCache on Windows does not work might be that the VS build script generator is not supporting ccache (yet)?
https://stackoverflow.com/a/73188028/2719194
https://cmake.org/cmake/help/v3.27/prop_tgt/LANG_COMPILER_LAUNCHER.html

I do that to make sure multi-config build generators work as expected, too.

We use Ninja as generator on AMReX Windows CI.
We can use Ninja for the Win Clang Debug build, too.

Use ccache in CIs. Set up GitHub Cache for storing the ccache data.
@WeiqunZhang
Copy link
Member Author

Unfortunately, the Ninja generator does not support toolset. I have restored windows.yml, since it does not work.

@ax3l
Copy link
Member

ax3l commented Sep 11, 2023

Thank you, let's address Windows CCache in a separate PR.

@ax3l ax3l merged commit 07b43c8 into AMReX-Codes:development Sep 11, 2023
@ax3l ax3l mentioned this pull request Sep 11, 2023
2 tasks
@ax3l ax3l added the enhancement New feature or request label Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants