Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add grow_low and high to Box #204

Merged
merged 2 commits into from
Oct 19, 2023

Conversation

dpgrote
Copy link
Contributor

@dpgrote dpgrote commented Oct 13, 2023

Implementing more things.

@ax3l ax3l self-assigned this Oct 19, 2023
@ax3l ax3l self-requested a review October 19, 2023 00:58
@ax3l ax3l added the enhancement New feature or request label Oct 19, 2023
Copy link
Member

@ax3l ax3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thank you!

@ax3l
Copy link
Member

ax3l commented Oct 19, 2023

Rebased to include 6ef5591

@ax3l ax3l enabled auto-merge (squash) October 19, 2023 05:04
@ax3l ax3l disabled auto-merge October 19, 2023 05:05
@ax3l ax3l merged commit ee6537d into AMReX-Codes:development Oct 19, 2023
1 check passed
@dpgrote dpgrote deleted the add_box_grow_low_high branch October 23, 2023 16:56
@dpgrote
Copy link
Contributor Author

dpgrote commented Oct 23, 2023

@ax3l I see the changes to the pyi files. Is this something that has to happen for every addition to the interface? Are these automatically generated?

@ax3l
Copy link
Member

ax3l commented Nov 20, 2023

@dpgrote they are auto-generated and used for documentation (Sphinx) and interactive auto-completion purposes :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants