feat(series): BubbleSeries (alpha) and markSizeAccessor (opensearch-p…

…roject#559)

- add `BubbleSeries` (alpha), like line without the line but uses a spatial index for point selection
- add `markSizeAccessor` prop to `area`, `line` and `bubble` chart types to set the mark radius

packages/osd-charts/.eslintignore

@@ -9,3 +9,4 @@
 /dist
 /coverage
 /.vscode
+src/utils/d3-delaunay/*

packages/osd-charts/.prettierignore

@@ -1,2 +1,2 @@
 *.md
-*.mdx
+*.mdx

packages/osd-charts/NOTICE.txt

@@ -21,4 +21,22 @@ FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
 AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
-SOFTWARE.
+SOFTWARE.
+
+---
+This product also includes code that is adapted from d3-delaunay@5.2.1,
+which is available under a "ISC" license.
+
+Copyright 2018 Observable, Inc.
+
+Permission to use, copy, modify, and/or distribute this software for any purpose
+with or without fee is hereby granted, provided that the above copyright notice
+and this permission notice appear in all copies.
+
+THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES WITH
+REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF MERCHANTABILITY AND
+FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY SPECIAL, DIRECT,
+INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES WHATSOEVER RESULTING FROM LOSS
+OF USE, DATA OR PROFITS, WHETHER IN AN ACTION OF CONTRACT, NEGLIGENCE OR OTHER
+TORTIOUS ACTION, ARISING OUT OF OR IN CONNECTION WITH THE USE OR PERFORMANCE OF
+THIS SOFTWARE.

packages/osd-charts/jest.config.js

@@ -20,7 +20,7 @@ module.exports = {
   roots: ['<rootDir>/src'],
   preset: 'ts-jest',
   testEnvironment: 'jest-environment-jsdom-fourteen',
-  setupFilesAfterEnv: ['jest-extended', '<rootDir>/scripts/setup_enzyme.ts', '<rootDir>/scripts/custom_matchers.ts'],
+  setupFilesAfterEnv: ['<rootDir>/scripts/setup_enzyme.ts', '<rootDir>/scripts/custom_matchers.ts'],
   coveragePathIgnorePatterns: ['<rootDir>/src/mocks/', '<rootDir>/node_modules/'],
   clearMocks: true,
   globals: {

packages/osd-charts/scripts/custom_matchers.ts

@@ -17,6 +17,7 @@
  * under the License. */
 
 import { matcherErrorMessage } from 'jest-matcher-utils';
+import 'jest-extended'; // require to load jest-extended matchers
 
 // ensure this is parsed as a module.
 export {};

packages/osd-charts/src/chart_types/partition_chart/layout/utils/__mocks__/d3_utils.ts

@@ -18,6 +18,10 @@
 
 const module = jest.requireActual('../d3_utils.ts');
 
+export const defaultColor = module.defaultColor;
+export const transparentColor = module.transparentColor;
+export const defaultD3Color = module.defaultD3Color;
+
 export const stringToRGB = jest.fn(module.stringToRGB);
 export const validateColor = jest.fn(module.validateColor);
 export const argsToRGB = jest.fn(module.argsToRGB);

packages/osd-charts/src/chart_types/specs.ts

@@ -18,12 +18,13 @@
 
 export {
   AreaSeries,
-  BarSeries,
-  LineSeries,
   Axis,
+  BarSeries,
+  BubbleSeries,
+  HistogramBarSeries,
   LineAnnotation,
+  LineSeries,
   RectAnnotation,
-  HistogramBarSeries,
 } from './xy_chart/specs';
 
 export * from './xy_chart/utils/specs';

packages/osd-charts/src/chart_types/xy_chart/annotations/annotation_utils.ts

@@ -91,7 +91,7 @@ export function scaleAndValidateDatum(dataValue: any, scale: Scale, alignWithTic
   const isContinuous = scale.type !== ScaleType.Ordinal;
   const scaledValue = scale.scale(dataValue);
   // d3.scale will return 0 for '', rendering the line incorrectly at 0
-  if (isNaN(scaledValue) || (isContinuous && dataValue === '')) {
+  if (scaledValue === null || (isContinuous && dataValue === '')) {
     return null;
   }
 

packages/osd-charts/src/chart_types/xy_chart/annotations/line_annotation_tooltip.ts

@@ -107,7 +107,7 @@ function computeYDomainLineAnnotationDimensions(
 
     const annotationValueYposition = yScale.scale(dataValue);
     // avoid rendering non scalable annotation values
-    if (isNaN(annotationValueYposition)) {
+    if (annotationValueYposition === null) {
       return;
     }
 

packages/osd-charts/src/chart_types/xy_chart/crosshair/crosshair_utils.ts

@@ -37,7 +37,7 @@ export function getSnapPosition(
   totalBarsInCluster = 1,
 ): { band: number; position: number } | undefined {
   const position = scale.scale(value);
-  if (position === undefined) {
+  if (position === null) {
     return;
   }