STYLE: Catch exceptions by _const_ reference #1361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following C++ Core Guidelines, April 10, 2022, which says that it is "typically better" to catch by const reference than to catch by non-const reference. At https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#e15-throw-by-value-catch-exceptions-from-a-hierarchy-by-reference Discussed at C++ Core Guidelines issue isocpp/CppCoreGuidelines#518 "Catch exceptions by const reference?", from February 3, 2016. find . -type f | egrep '\.[it]?(cc|hh|[ch](\+\+|pp?|xx)?)$' | fgrep -v ThirdParty | xargs sed -r -i -e 's/catch \((const )?/catch (const /g' -e 's/catch \(const \.\.\.\)/catch (...)/g'
|
Awesome. Thanks @hjmjohnson |
|
Looks like an extra const somewhere, I'll check this out and try to fix the other warning I introduced to antsMotionCorr |
cookpa
reviewed
May 13, 2022
| @@ -87,7 +87,7 @@ ANTSex(int argc, char * argv[]) | |||
| { | |||
| registration->RunRegistration(); | |||
| } | |||
| catch (std::exception const & e) | |||
| catch (const std::exception const & e) | |||
|
Sorry @hjmjohnson I might be doing something wrong or you didn't check the "allow edits by maintainers" box on the PR, but I can't seem to push to this. But I did compile so the extra "const" in ANTS.cxx is the only thing preventing the build. |
|
Going to merge and make that one fix |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following C++ Core Guidelines, April 10, 2022, which says that it is "typically
better" to catch by const reference than to catch by non-const reference. At
https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#e15-throw-by-value-catch-exceptions-from-a-hierarchy-by-reference
Discussed at C++ Core Guidelines issue isocpp/CppCoreGuidelines#518 "Catch
exceptions by const reference?", from February 3, 2016.
find . -type f | egrep '.[it]?(cc|hh|ch?)$' | fgrep -v ThirdParty | xargs sed -r -i -e 's/catch ((const )?/catch (const /g' -e 's/catch (const ...)/catch (...)/g'