Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not prepend v to version #1504

Merged
merged 1 commit into from
Mar 24, 2023

Conversation

DimitriPapadopoulos
Copy link
Contributor

Description

Debian expects upstream version to start with a digit. See deb-version(7) man page:

The upstream-version may contain only alphanumerics (“A-Za-z0-9”)
and the characters . + - : ~ (full stop, plus, hyphen, colon,
tilde) and should start with a digit. If there is no debian-
revision then hyphens are not allowed; if there is no epoch then
colons are not allowed.

Tools such as dpkg have started enforcing this rule and bail out with an error message if the version of a DEB package starts with v2.4.3 instead of 2.4.3:

$ sudo dpkg -i ANTs-v2.4.3.post10-g871cad0-Linux.deb
dpkg: error processing archive ANTs-v2.4.3.post10-g871cad0-Linux.deb (--install):
 parsing file '/var/lib/dpkg/tmp.ci/control' near line 374 package 'ants':
 'Version' field value 'v2.4.3.post10-g871cad0': version number does not start with digit
Errors were encountered while processing:
 ANTs-v2.4.3.post10-g871cad0-Linux.deb

Fixes #1503.

Debian expects upstream version to start with a digit. See
deb-version(7) man page:
https://manpages.debian.org/bullseye/dpkg-dev/deb-version.7

Tools such as dpkg have started enforcing this rule and bail out with an
error message if the ANTs version starts with `v2.4.3` instead of `2.4.3`.
@cookpa
Copy link
Member

cookpa commented Mar 1, 2023

I'm OK with this in principle but would need some time to test it didn't interfere with the runners / releases

@cookpa
Copy link
Member

cookpa commented Mar 24, 2023

I think this might just work, after reviewing other files. The tags would continue to be vX.Y.Z, but the version built into the project can just be X.Y.Z. Merging for now (after CI testing) then testing the release

@cookpa cookpa merged commit 0959935 into ANTsX:master Mar 24, 2023
@DimitriPapadopoulos DimitriPapadopoulos deleted the PROJECT_NAME_VERSION branch March 25, 2023 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cmake -DCPACK_BINARY_DEB=ON and CPACK_PACKAGE_VERSION
2 participants