Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: write template output such that things sort together #1771

Merged
merged 4 commits into from
Jul 18, 2024

Conversation

cookpa
Copy link
Member

@cookpa cookpa commented Jul 15, 2024

A few fixes

  • Replaced all the "let" statements and other traps that prevent running with bash -e, and turned that on.

  • Fixed error checking in pairwise registration stage

  • Attempted to make output more readable by prefixing input indices, rather than adding them at the end. Trying to make things easier to list and review, especially with multiple modalities

@cookpa
Copy link
Member Author

cookpa commented Jul 15, 2024

Editing bash is always scary but I have run both the faces and the brain slices example successfully

@gdevenyi
Copy link
Contributor

If you're willing to go through some painful testing, this is the gold standard,
http://redsymbol.net/articles/unofficial-bash-strict-mode/

And even more painful, getting to pass, https://github.com/koalaman/shellcheck

@cookpa
Copy link
Member Author

cookpa commented Jul 16, 2024

Thanks @gdevenyi

@cookpa cookpa merged commit 5debf14 into master Jul 18, 2024
1 check passed
@cookpa cookpa deleted the template_output_formatting branch July 18, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants