Skip to content

Commit

Permalink
SEC: Shouldn't have API tokens in the repo
Browse files Browse the repository at this point in the history
  • Loading branch information
@cookpa
cookpa committed Mar 22, 2024
1 parent 735dfcc commit cd1e956
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion tests/.coveralls.yml
View file

This file was deleted.

3 comments on commit cd1e956

@gdevenyi
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://docs.github.com/en/authentication/keeping-your-account-and-data-secure/removing-sensitive-data-from-a-repository

@gdevenyi
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cookpa

@cookpa
Copy link
Member Author

@cookpa cookpa commented on cd1e956 Mar 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - fortunately coveralls make it very easy to replace the token with a new one, so I won't need to scrub it. And the action now uses the github token directly, so there's not even any need to keep it as a secret for the runners.

Please sign in to comment.