Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why isn't there a windows version? Compiled whl files #398

Closed
464hee opened this issue Sep 7, 2022 · 25 comments
Closed

Why isn't there a windows version? Compiled whl files #398

464hee opened this issue Sep 7, 2022 · 25 comments

Comments

@464hee
Copy link

464hee commented Sep 7, 2022

I think the tool is good, but it's too hard to install under Win10

@464hee
Copy link
Author

464hee commented Sep 8, 2022

pip install https://github.com/SGotla/ANTsPy/releases/download/0.1.7Win64/antspy-0.1.7-cp37-cp37m-win_amd64.whl

I found a solution in my previous question.Thank him for his dedication

@464hee
Copy link
Author

464hee commented Sep 8, 2022

It would be nice to have the latest version

@ntustison
Copy link
Member

You’re right. However, we don’t have windows machines so it’s difficult for us to support that platform.

@464hee
Copy link
Author

464hee commented Sep 8, 2022

You’re right. However, we don’t have windows machines so it’s difficult for us to support that platform.

You can use the cloud platform to achieve the windows environment testing

@ntustison
Copy link
Member

If you were so inclined, that would be a much appreciated contribution.

@dyollb
Copy link
Contributor

dyollb commented Sep 29, 2022

@ntustison I see the wheels.yml seems to have windows builds and recent CI builds on github contain the wheels in the artifacts. Are you planning to push any of those to pypi?

BTW: the ITK external modules use a github action like this. This zips the different platform versions as separate artifacts and if the push/pull_request is tagged with something starting with "v" (e.g. v1.2.3) it is uploaded to pypi.

@stnava
Copy link
Member

stnava commented Sep 29, 2022

the wheels are too big to push all to pypi ... we have limited storage there. also, I don't think anyone has actually tested the windows wheels.

@kchawla-pi
Copy link

What are the sticking points/blockers in building windows wheels? I may want to look into trying to build them. Anything I need to know? Any guidance that would benefit me?

@kchawla-pi
Copy link

BTW Azure Pipelines has robust windows build support and is generous to opensource projects.

@stnava
Copy link
Member

stnava commented Jan 7, 2023

we would like to have windows builds but none of the core developers use or even have access to windows machines ... more critically, no time either.

@kchawla-pi
Copy link

I read that. I am volunteering my time and my windows machine. Would the project be interested? If yes, anything I should know that is not obviously documented, before I start?

@kchawla-pi
Copy link

kchawla-pi commented Jan 9, 2023

You already have a Windows in the wheels.yml , and are unable to test it and host it on PyPI due to limited size. So it is not a technical bottleneck, but a testing and cloud resource one?

@kchawla-pi
Copy link

If you were so inclined, that would be a much appreciated contribution.

If this has not been worked on, I will take a look.

@stnava
Copy link
Member

stnava commented Jan 9, 2023

that's great and much appreciated. I don't think the windows release actually works .... some testing would be good .... eg run the examples or something .... we could also use updated documentation of how one might compile on windows. @cookpa any thoughts on this?

@kchawla-pi
Copy link

kchawla-pi commented Jan 9, 2023

Cool! Also, if I use Azure Pipelines instead of Appveyor, would that fly with the project?

The Nilearn project used to use Appveyor, and it was pretty limited so I switched it to Azure Pipelines when I was working for Nilearn, and we were much happier for it.

@stnava
Copy link
Member

stnava commented Jan 9, 2023

yes - we are happy to have any help - very thankful ...

@kchawla-pi
Copy link

Thank you all for your excellent work for all of us.

@cookpa
Copy link
Member

cookpa commented Jan 9, 2023

This sounds great. I don't use Windows, but I have done a bit of work on the CI / deployment through Github actions for other platforms. I'm happy to help where I can.

There have been a few contributors who helped with cross-platform builds: @ravnoor and @tfmoraes - no pressure, I'm just tagging in case of interest in this issue in any capacity.

Anyone else reading this who would be interested in helping develop or use Windows builds, please join in this thread.

@tfmoraes
Copy link
Contributor

I tested on Windows when I submitted the PR to use the Github CI to generate the Wheels. It's running on Windows, but registration and other parts were not running, see #345 (comment)

@cookpa
Copy link
Member

cookpa commented Mar 23, 2023

Thanks for all the wheel building help, the last step was the pointer parsing in ANTs. It should work as of #442

@cookpa cookpa closed this as completed Mar 23, 2023
@kchawla-pi
Copy link

kchawla-pi commented Mar 23, 2023 via email

@stnava
Copy link
Member

stnava commented Mar 23, 2023 via email

@stnava
Copy link
Member

stnava commented Mar 23, 2023

https://pypi.org/project/antspyx/0.3.8/#files

note the long-awaited windows wheels @dorianps thanks to @cookpa ... hoping these continue to work for ppl.

his solution will also enable windows builds for ANTsR .... (eventually)

@464hee
Copy link
Author

464hee commented Mar 24, 2023

Thank you for your work

@dorianps
Copy link

dorianps commented Mar 24, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants