Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: Change collapse strategy. #419

Merged
merged 1 commit into from
Jan 6, 2023
Merged

ENH: Change collapse strategy. #419

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ants/lib/LOCAL_sliceImage.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ py::capsule sliceImage( py::capsule antsImage, int plane, int slice)

filter->SetExtractionRegion( desiredRegion );
filter->SetInput( itkImage );
filter->SetDirectionCollapseToSubmatrix();
filter->SetDirectionCollapseToGuess();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does this do? just concerned about backward compatibility issues as I have lots of data processed the old way ( sub matrix )

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps better to add a command line option and keep the old behavior as default

filter->Update();

return wrap<SliceImageType>( filter->GetOutput() );
Expand Down