Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Update coveralls version #592

Merged
merged 1 commit into from
Mar 22, 2024
Merged

ENH: Update coveralls version #592

merged 1 commit into from
Mar 22, 2024

Conversation

cookpa
Copy link
Member

@cookpa cookpa commented Mar 22, 2024

Bumping the version, hoping to avoid coverage errors.

On coveralls.io, docstrings are being interpreted as uncovered code. This seems to only be a problem on multi-line function definitions.

https://coveralls.io/builds/66464549/source?filename=home%2Frunner%2F.local%2Flib%2Fpython3.10%2Fsite-packages%2Fants%2Fsegmentation%2Fatropos.py

I don't see this issue on my local machine if I run the tests

@cookpa cookpa merged commit 291d02b into master Mar 22, 2024
1 check passed
@cookpa cookpa deleted the update-coverage-workflow branch March 22, 2024 16:23
@cookpa
Copy link
Member Author

cookpa commented Mar 22, 2024

Didn't help, it's still counting docstrings. Doesn't happen on my mac with the same coverage version (7.4.4).

@ncullen93
Copy link
Member

Ah weird... is a docstring supposed to be a ' instead of " ? Maybe that will help.

@cookpa
Copy link
Member Author

cookpa commented Mar 22, 2024

I think they are supposed to be double quotes - I might try exporting the coverage results to XML

@cookpa
Copy link
Member Author

cookpa commented Mar 22, 2024

OK XML worked. It looks correct now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants