Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Trying to use bash on windows #654

Merged
merged 3 commits into from
May 23, 2024
Merged

CI: Trying to use bash on windows #654

merged 3 commits into from
May 23, 2024

Conversation

cookpa
Copy link
Member

@cookpa cookpa commented May 23, 2024

No description provided.

@coveralls
Copy link

coveralls commented May 23, 2024

Coverage Status

coverage: 81.331%. remained the same
when pulling d39cbae on windows_test_output
into e481830 on master.

cibuildwheel tries to find tests automatically and run with pytest. This
bypasses some code for test verbosity, so better to run tests in the
dedicated test step. This will help us see what tests fail
@cookpa
Copy link
Member Author

cookpa commented May 23, 2024

Hi @ncullen93 I changed the tests on Windows to run the bash script run_tests.sh. Turns out that wasn't the cause of my problem (lack of test verbose output) but as a side effect I noticed that Windows now passes all the tests that run on other platforms.

@cookpa cookpa merged commit 8cceaed into master May 23, 2024
18 checks passed
@cookpa cookpa deleted the windows_test_output branch May 23, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants