Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid recompiling #10

Closed
chikamichi opened this issue Apr 22, 2014 · 6 comments · Fixed by #26
Closed

Avoid recompiling #10

chikamichi opened this issue Apr 22, 2014 · 6 comments · Fixed by #26

Comments

@chikamichi
Copy link
Contributor

Hi,

I wonder whether you'd like this role avoiding recompiling nginx?

When I use it several times in a row (for instance with vagrant provision, because I made some changes to my stack), it always recompile nginx although this is useless in this use case.

@pjan
Copy link
Contributor

pjan commented Apr 23, 2014

It would of course make sense, and I would very much prefer it to be done like this

It would have to be done with an only_when and quite a number of flags to be registered.

I'm not really sure if it can be done easily.

@iamcarrico
Copy link
Contributor

I am going to +1 this one, and mention when I do this to my vagrant machine--- it causes multiple instances of nginx to be running. Idea: could we just have a variable that we can set ourselves per-host? So, if we have "skip_nginx_compile: true" in a host_vars file--- it skips? A temporary stop-gap?

@mirzu
Copy link

mirzu commented Nov 26, 2014

+1

@farridav
Copy link

Perhaps you could write out the flags nginx was compiled to into a file and diff them in the task to see if it needs recompiling... I also had the issue with the old nginx still running, and I now use a handler for killing nginx processes on each re-provision..

farridav pushed a commit to farridav/nginx that referenced this issue Jan 12, 2015
@farridav
Copy link

Had a spare min so i put up a PR for this, let me know if fits the bill...

@pjan pjan closed this as completed in #26 Jan 26, 2015
pjan added a commit that referenced this issue Jan 26, 2015
@chikamichi
Copy link
Contributor Author

Thank you @farridav

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants