Add geoip module support #46
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
|
I don't understand why Travis build fails. There's no failed task |
|
@pjan up |
|
The first travis pass succeeds. The idempotency test fails. After fixing the |
|
I just fix the last version number of OpenSSL here : https://github.com/welcoMattic/nginx/pull/1. I pull it into my geoip to avoid build failing. |
|
@otakup0pe what's your testing workflow on local? I can't reproduce TravisCI workflow with success. |
Merge from original repo
|
@otakup0pe @pjan LGTM |
Closed
Merged
|
Did we merge this in a different PR? If not, let's get the conflicts sorted so we can merge. |
|
It was merged in #66. We can close this PR, I think |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #4