Fixed installation of dev_headers and postgis on RedHat #200
Conversation
| with_items: | ||
| - "postgis2_{{postgresql_version_terse}}" | ||
| - "postgis2_{{postgresql_version_terse}}-client" | ||
| - "postgis2_{{postgresql_version_terse}}-devel" |
There was a problem hiding this comment.
It's really need for production server install devel and docs?
There was a problem hiding this comment.
Not necessarily. This could be made conditional on postgresql_ext_install_dev_headers, assuming that if you want the development files for PostgreSQL itself you also want the PostGIS development files. What do you think?
There was a problem hiding this comment.
PostgreSQL dev headers not corellate with postgis extension. I think, installation of dev packages should be manually. For production use its not necessary.
There was a problem hiding this comment.
I agree that the dev packages are not required for production use. On the other hand the role already has the option to install dev packages (headers) if one choses so. So my thought was that if you install the PostgreSQL dev packages and chose to select PostGIS there is a good chance that the user wants the PostGIS dev package, too. Having to install it manually defeats the purpose of automation. For example, I am using the role together with Vagrant to create a PostGIS development server.
There was a problem hiding this comment.
If the dev headers for postgresql aren't needed when installing the postgis basics then it shouldn't get conflated. I'm guessing this is how the https://github.com/ANXS/utilities role came about originally heh.
| with_items: | ||
| - "postgis2_{{postgresql_version_terse}}-devel" | ||
| - "postgis2_{{postgresql_version_terse}}-docs" | ||
| when: (ansible_os_family == "RedHat") and (postgresql_ext_install_dev_headers) |
There was a problem hiding this comment.
when: ansible_os_family == "RedHat" and {{ postgresql_ext_install_dev_headers | default(false) }}
There was a problem hiding this comment.
Or add this variable into defaults file
|
Can this get merged in now? |
|
@taybin Fine with me. |
This fixes the problem that there where o steps to install dev_headers and postgis on RedHat. This should also fix issue #194.
Markus