Skip to content
This repository has been archived by the owner on Sep 12, 2022. It is now read-only.

updated composer.json #20

Merged
merged 1 commit into from
Jan 25, 2018
Merged

updated composer.json #20

merged 1 commit into from
Jan 25, 2018

Conversation

sprankhub
Copy link
Contributor

Since the composer.json in the development branch refers to ecomdev/ecomdev_phpunit (see https://github.com/AOEpeople/EcomDev_PHPUnit/blob/dev/composer.json), we should refer to ecomdev here as well.

Since the `composer.json` in the development branch refers to `ecomdev/ecomdev_phpunit` (see https://github.com/AOEpeople/EcomDev_PHPUnit/blob/dev/composer.json), we should refer to `ecomdev` here as well.
@kkrieger85
Copy link
Contributor

I tested the proposed change with my own fork: All testes passes.

See also https://travis-ci.org/firegento/firegento-adminmonitoring/builds/288140926

@sprankhub
Copy link
Contributor Author

Could you please merge this? /cc @thebod

1 similar comment
@sprankhub
Copy link
Contributor Author

Could you please merge this? /cc @thebod

@jadhub jadhub merged commit d386515 into AOEpeople:master Jan 25, 2018
@sprankhub sprankhub deleted the patch-1 branch January 25, 2018 10:29
@mehdichaouch
Copy link

mehdichaouch commented Jan 29, 2018

I don't know why since this was merged I get this error in my build:

The requested package ecomdev/ecomdev_phpunit could not be found in any version, there may be a typo in the package name

Do you have issue like this ?

@kkrieger85
Copy link
Contributor

For some reason ecomdev_phpunit is not listed on packagist.org

https://packagist.org/?q=ecomdev_phpunit&p=0

@kkrieger85
Copy link
Contributor

One solution could be to add packages.firegento.org as source:


    "repositories": [
        {
            "type": "composer",
            "url": "https://packages.firegento.com"
        }
    ]

kkrieger85 pushed a commit to kkrieger85/MageTestStand that referenced this pull request Jan 29, 2018
@mehdichaouch
Copy link

mehdichaouch commented Jan 29, 2018

This solved issue, hope to get this merge quickly ;)
Thank you @kkrieger85

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants