feat: allow selecting multiple tags #482
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nekrich
commented
Sep 12, 2024
| @@ -14,13 +15,49 @@ type TagProps = { | |||
| } & Omit<LinkProps, "href"> & | |||
| ComponentPropsWithoutRef<"a">; | |||
|
|
|||
| function QueryString(tag: string, isActive: boolean | undefined) { | |||
There was a problem hiding this comment.
Self-review:
I could find a quick way to convert router.query to URLSearchParams and had to write the QueryString function.
I've tried new URLSearchParams(router.query as Record<string, string>),. It converts arrays to coma-separated strings, and I lose query parameters type-safety when working with string.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow selecting multiple tags.
ANDlogic. Blip must contain all selected tags to be shown.Related issue: #464.
tag=query parameter is still supported for backward compatibility.