Skip to content

Commit

Permalink
Add macOS artifacts to release (#2461)
Browse files Browse the repository at this point in the history
The binaries are not notarized, see #2460
  • Loading branch information
maryla-uc authored Oct 2, 2024
1 parent fd66e9d commit 5e38bec
Show file tree
Hide file tree
Showing 4 changed files with 89 additions and 16 deletions.
5 changes: 4 additions & 1 deletion .github/actions/setup-macos/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,10 @@ runs:
sudo rm -rf /Library/Frameworks/Python.framework/
brew install --force python3 && brew unlink python3 && brew unlink python3 && brew link --overwrite python3
shell: bash
- name: Install non-library dependencies
- name: Install non-library test dependencies
# imagemagick is used in sh tests (not gtest tests) but we assume that no tests are run by the CI
# if gtest is off
if: ${{ inputs.gtest != 'OFF' }}
run: brew install imagemagick
shell: bash
- name: Install AOM library
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# This workflow generates artifacts such as avifenc and avifdec for convenience.

name: CI Unix Static
name: CI Linux Release Artifacts
on:
release:
types: [created]
Expand All @@ -9,26 +9,20 @@ permissions:
contents: read

jobs:
build-static:
build-linux-artifacts:
runs-on: ${{ matrix.os }}
strategy:
fail-fast: false
matrix:
os: [ubuntu-latest] # TODO: macos-latest
os: [ubuntu-latest]

steps:
- uses: actions/checkout@d632683dd7b4114ad314bca15554477dd762a938 # v4.2.0
- uses: ./.github/actions/setup-linux
if: runner.os == 'Linux'
with:
codec-aom: "LOCAL"
codec-dav1d: "LOCAL"
libyuv: "LOCAL"
- uses: ./.github/actions/setup-macos
if: runner.os == 'macOS'
with:
codec-aom: "LOCAL"
codec-dav1d: "LOCAL"

- name: Prepare libavif (cmake)
run: >
Expand All @@ -49,7 +43,7 @@ jobs:
uses: thedoctor0/zip-release@b57d897cb5d60cb78b51a507f63fa184cfe35554 # 0.7.6
with:
type: zip
filename: ${{ runner.os }}-artifacts.zip
filename: linux-artifacts.zip
directory: build
path: |
avifenc
Expand All @@ -61,13 +55,13 @@ jobs:
with:
# See https://docs.github.com/en/webhooks/webhook-events-and-payloads#release.
upload_url: ${{ github.event.release.upload_url }}
asset_path: build/${{ runner.os }}-artifacts.zip
asset_name: ${{ runner.os }}-artifacts.zip
asset_path: build/linux-artifacts.zip
asset_name: linux-artifacts.zip
asset_content_type: application/zip

# Use the following instead of the above to test this workflow outside of a release event.
# - name: Upload artifacts
# uses: actions/upload-artifact@50769540e7f4bd5e21e526ee35c689e35e0d6874 # v4.4.0
# with:
# name: ${{ runner.os }}-artifacts.zip
# path: build/${{ runner.os }}-artifacts.zip
# name: linux-artifacts.zip
# path: build/linux-artifacts.zip
76 changes: 76 additions & 0 deletions .github/workflows/ci-macos-artifacts.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,76 @@
# This workflow generates artifacts such as avifenc and avifdec for convenience.

name: CI macOS Release Artifacts
on:
release:
types: [created]

permissions:
contents: read

jobs:
build-macos-artifacts:
runs-on: ${{ matrix.os }}
strategy:
fail-fast: false
matrix:
os: [macos-latest]

steps:
- uses: actions/checkout@d632683dd7b4114ad314bca15554477dd762a938 # v4.2.0
- uses: ./.github/actions/setup-macos
with:
codec-aom: "LOCAL"
codec-dav1d: "LOCAL"

- name: Prepare libavif (cmake)
run: >
cmake -G Ninja -S . -B build
-DCMAKE_BUILD_TYPE=Release -DBUILD_SHARED_LIBS=OFF
-DAVIF_CODEC_AOM=LOCAL -DAVIF_CODEC_AOM_ENCODE=ON
-DAVIF_CODEC_AOM_DECODE=OFF -DAVIF_CODEC_DAV1D=LOCAL
-DAVIF_LIBSHARPYUV=LOCAL -DAVIF_LIBYUV=LOCAL
-DAVIF_ZLIBPNG=LOCAL -DAVIF_JPEG=LOCAL
-DAVIF_BUILD_EXAMPLES=OFF -DAVIF_BUILD_APPS=ON
-DAVIF_BUILD_TESTS=OFF -DAVIF_ENABLE_WERROR=ON
-DCMAKE_C_COMPILER=clang
- name: Build libavif (ninja)
working-directory: ./build
run: ninja
# TODO: notarize the binaries
- name: Create README.txt
run: |
cat <<'EOF' > build/README.txt
For security reasons, macOS might prevent these binaries from running.
If you get a message saying that "Apple cannot check it for malicious software",
run this command once:
$ sudo xattr -r -d com.apple.quarantine ./avifenc ./avifdec
See also https://github.com/AOMediaCodec/libavif/issues/2460
EOF
- name: Archive artifacts
uses: thedoctor0/zip-release@b57d897cb5d60cb78b51a507f63fa184cfe35554 # 0.7.6
with:
type: zip
filename: ${{ runner.os }}-artifacts.zip
directory: build
path: |
avifenc
avifdec
README.txt
- name: Upload artifacts
uses: actions/upload-release-asset@e8f9f06c4b078e705bd2ea027f0926603fc9b4d5 # v1.0.2
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with:
# See https://docs.github.com/en/webhooks/webhook-events-and-payloads#release.
upload_url: ${{ github.event.release.upload_url }}
asset_path: build/${{ runner.os }}-artifacts.zip
asset_name: ${{ runner.os }}-artifacts.zip
asset_content_type: application/zip

# Use the following instead of the above to test this workflow outside of a release event.
# - name: Upload artifacts
# uses: actions/upload-artifact@50769540e7f4bd5e21e526ee35c689e35e0d6874 # v4.4.0
# with:
# name: ${{ runner.os }}-artifacts.zip
# path: build/${{ runner.os }}-artifacts.zip
2 changes: 1 addition & 1 deletion .github/workflows/ci-windows-artifacts.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# This workflow generates artifacts such as avifenc.exe and avifdec.exe for convenience.

name: CI Windows Artifacts
name: CI Windows Release Artifacts
on:
release:
types: [created]
Expand Down

0 comments on commit 5e38bec

Please sign in to comment.