Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable compiler warnings in fuzztest targets #2356

Merged

Conversation

wantehchang
Copy link
Collaborator

@wantehchang wantehchang commented Aug 1, 2024

Pass the SYSTEM argument to add_subdirectory(ext/fuzztest) to treat
FuzzTest headers as system headers. This suppresses compiler warnings in
FuzzTest headers.

Fix #2350.

Pass the SYSTEM argument to add_subdirectory(ext/fuzztest) to treat
FuzzTest headers as system headers. This suppresses compiler warnings in
FuzzTest headers.

Fix AOMediaCodec#2350.
@wantehchang wantehchang force-pushed the enable-warnings-in-fuzztest-targets branch from 809916b to 3198490 Compare August 1, 2024 14:31
@wantehchang wantehchang marked this pull request as ready for review August 1, 2024 15:17
@wantehchang wantehchang requested a review from jzern August 1, 2024 15:19
@wantehchang
Copy link
Collaborator Author

@vrabaud FYI. This uses the SYSTEM directory property that you suggested.

Copy link
Collaborator

@jzern jzern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested with cmake 3.21, it fails as expected. Building with 3.29.6 works.

@wantehchang wantehchang merged commit 622ec93 into AOMediaCodec:main Aug 1, 2024
32 checks passed
@wantehchang wantehchang deleted the enable-warnings-in-fuzztest-targets branch August 1, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider enabling compiler warnings in add_avif_fuzztest() in tests/CMakeLists.txt
2 participants