Add custom codec callback in avifEncoder #2381
Conversation
There was a problem hiding this comment.
Yannis: I only took a cursory look at this pull request. The commit message has the subject line "Add custom codec callback in avifEncoder". That is confusing, because these callbacks do not seem to provide access to a custom AV1 codec. Should we change "custom codec" to "custom encode data"?
| int tileColsLog2, | ||
| int quantizer, | ||
| avifBool disableLaggedOutput, | ||
| avifAddImageFlags addImageFlags); |
There was a problem hiding this comment.
This will become part of the public API, so we need to make it easy to extend. One way to do that is to collect the indivisual parameters (tileRowsLog2, ..., disableLaggedOutput) into a parameter structure that is extensible. (There are several ways to define an extensible structure.)
Thank you. This PR is a proof-of-concept to kickstart a discussion, not a request to merge code.
I did not mention AV1. This could be used for any kind of coded samples (AV2?) but to be compliant with the AVIF specification it would have to be AV1 samples indeed.
To me the piece of software that generates encoded data is a codec, so "custom codec callback" is accurate. Whether that is used to feed already compressed samples or to actually encode pixels on the spot, it is opaque to the libavif API. |
No description provided.