Bump AVM to research-8.0.0 #2437
Draft
+9
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wantehchang
reviewed
Sep 23, 2024
| @@ -39,6 +39,10 @@ jobs: | |||
| gcc-version: ${{ matrix.gcc }} | |||
| libyuv: 'LOCAL' | |||
|
|
|||
| - name: Install cpuinfo | |||
| run: | |||
| sudo apt install -y cpuinfo | |||
There was a problem hiding this comment.
Why do we need to install cpuinfo here? It would be good to mention this in the commit message.
| @@ -89,13 +89,15 @@ else() | |||
| endif() | |||
|
|
|||
| if(AVIF_CODEC_AVM) | |||
| # TODO(vrabaud) remove the PATCH_COMMAND once upstream is fixed. | |||
There was a problem hiding this comment.
Optional: It would be good to link to a merge request for the AVM upstream.
wantehchang
reviewed
Sep 25, 2024
vrabaud
force-pushed
the
main
branch
2 times, most recently
from
4f2d7b2
to
783a2e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.