-
-
Notifications
You must be signed in to change notification settings - Fork 145
[feat]: InMemorySaver() introduction with custom reducers and summarization node for context handling #75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
8855701
[feature]: add summarization node for context summarization for state…
smokeyScraper 6fa867c
[refactor]: introduce state reducers in agent
smokeyScraper 2892957
[refactor]: update nodes to support new reducer states
smokeyScraper 6c2fcd4
[refactor]: update devrel/agent to support reducers
smokeyScraper 22536a8
[refactor]: update base prompt to support context and summary
smokeyScraper a7d4122
[feature]: introduce state handling in discord bot
smokeyScraper ebb0154
[refactor]: coderabbit suggested changes
smokeyScraper 897b5fb
[chore]: add missing module to poetry
smokeyScraper 2952ac8
[bugfix]: add clear_thread_memory in class to be called via self
smokeyScraper File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty file.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Share a single
InMemorySaverinstead of instantiating per-agentself.checkpointer = InMemorySaver()creates a brand-new store for everyDevRelAgentinstance.If the application spins up a fresh agent per request (very common in serverless / web frameworks), each request will operate on an isolated store and no memory carry-over will occur, defeating the whole purpose of the saver.
Create one saver at module level (or inject it from the orchestrator) and reuse it across agents:
No other code changes are required because
workflow.compile(checkpointer=…)already accepts the instance.This minor refactor preserves true cross-session memory and avoids silent data loss.
Also applies to: 91-92
🤖 Prompt for AI Agents
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a problem as only one instance lives for the entire application lifetime with thread and InMemorySaver() based system to remember user conversations throughout.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@smokeyScraper, thank you for the clarification! That makes perfect sense - with a singleton DevRelAgent instance living for the entire application lifetime, the InMemorySaver created in the constructor will indeed be shared across all conversations through the thread-based system. This architecture effectively achieves memory persistence without the isolation concerns I raised. I appreciate you explaining the application's design pattern.
✏️ Learnings added