Skip to content

bug: fixed favicon and title of default vite app #1127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
saurabh007007 wants to merge 2 commits into from
Closed

bug: fixed favicon and title of default vite app #1127

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6d8d177
fix:footer dark and light mode fixed
saurabh007007 Feb 2, 2026
14d22de
bug:fixed favicon and title of default vite app
saurabh007007 Feb 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions frontend/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,17 @@
<html lang="en">
<head>
<meta charset="UTF-8" />
<link rel="icon" type="image/svg+xml" href="/vite.svg" />
<link
rel="icon"
type="image/png"
href="https://aossie-org.github.io/PictoPy/assets/favicon.png"
/>
Comment on lines +5 to +9
Copy link

Copilot AI Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The favicon is being loaded from an external GitHub Pages URL, which creates an external dependency and may cause issues if the GitHub Pages site is unavailable or if the application is used offline. Consider copying the favicon to the frontend/public directory (similar to how 128x128.png and tauri.svg exist there) and referencing it as a local asset with href="/favicon.png" instead. A local copy of the favicon already exists at docs/assets/favicon.png and could be copied to frontend/public/.

Copilot uses AI. Check for mistakes.
<meta
Copy link

Copilot AI Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an extra space at the beginning of this line, which breaks indentation consistency. The line should start with 4 spaces (to match the indentation of the link element above and the meta element below) instead of 5 spaces.

Suggested change
<meta
<meta

Copilot uses AI. Check for mistakes.
name="description"
content="PictoPy - Advanced desktop gallery application powered by Tauri, React, and Rust"
/>
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<title>Tauri + React + Typescript</title>
<title>PictoPy</title>
</head>

<body>
Expand Down
1 change: 0 additions & 1 deletion frontend/public/vite.svg
View file
Open in desktop

This file was deleted.

10 changes: 5 additions & 5 deletions landing-page/src/Pages/Footer/Footer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { FaDiscord } from 'react-icons/fa' // Import Discord icon from React Ic

const Footer: React.FC = () => {
return (
<footer className="relative bg-black text-white py-8 overflow-hidden">
<footer className="relative bg-white dark:bg-black text-gray-900 dark:text-white py-8 overflow-hidden transition-colors duration-300 border-t border-gray-100 dark:border-gray-900">
Copy link

Copilot AI Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Footer.tsx changes (adding dark mode styling and border) are unrelated to the PR's stated purpose of fixing the default Vite favicon and title. These changes should be separated into a different PR focused on adding dark mode support to the footer component.

Copilot uses AI. Check for mistakes.
<div className="relative container mx-auto px-6">
<div className="flex justify-between items-center">
{/* Left-aligned PictoPy text */}
Expand All @@ -15,10 +15,10 @@ const Footer: React.FC = () => {

{/* Right-aligned Discord Icon and "Made with love" text */}
<div className="flex items-center space-x-2">
<a
href="https://discord.com/channels/1022871757289422898/1311271974630330388"
target="_blank"
rel="noopener noreferrer"
<a
href="https://discord.com/channels/1022871757289422898/1311271974630330388"
target="_blank"
rel="noopener noreferrer"
className="text-sm font-medium text-transparent bg-clip-text bg-gradient-to-r from-yellow-400 to-green-400 hover:bg-gradient-to-r hover:from-yellow-500 hover:to-green-500 transition duration-300 ease-in-out"
>
<FaDiscord className="inline-block mr-2 text-yellow-400 hover:text-green-400 transition duration-300 ease-in-out transform scale-150" /> {/* Scale it to 1.5x */}
Expand Down
Loading