Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UI] Notifications Screen with mock data #337

Merged
merged 4 commits into from
Oct 1, 2024
Merged

[UI] Notifications Screen with mock data #337

merged 4 commits into from
Oct 1, 2024

Conversation

AyaNady17
Copy link
Contributor

@AyaNady17 AyaNady17 commented Aug 12, 2024 •
edited
Loading

Description

Implemented notifications screen UI with mock data

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (does not change functionality, e.g. code style improvements, linting)
  • Documentation update

How Has This Been Tested?

tested manually

Please include screenshots below if applicable.
Screenshot_1723498365

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • [] I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Maintainer Checklist

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tag the PR with the appropriate labels

@AyaNady17
Copy link
Contributor Author

please review @Aarush-Acharya @vrundraval24

chandansgowda
chandansgowda requested changes Sep 14, 2024
View reviewed changes
Copy link
Member

@chandansgowda chandansgowda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor changes

lib/views/new_screens/new_notifications_screen.dart Outdated
padding: const EdgeInsets.only(right: 16.0, left: 16),
child: InkWell(
child: const CircleAvatar(
backgroundImage: NetworkImage(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use an asset image here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

lib/views/new_screens/new_notifications_screen.dart Outdated
}
}

class NotificationModel {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move this to models folder

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@Aarush-Acharya
Copy link
Contributor

@chandansgowda @AyaNady17 Looks good to me

@AyaNady17
Copy link
Contributor Author

please check this @chandansgowda

@Aarush-Acharya Aarush-Acharya merged commit ecd8c9c into AOSSIE-Org:dev Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vrundraval24 vrundraval24 Awaiting requested review from vrundraval24

@Aarush-Acharya Aarush-Acharya Awaiting requested review from Aarush-Acharya

@chandansgowda chandansgowda Awaiting requested review from chandansgowda

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AyaNady17 @Aarush-Acharya @chandansgowda