Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Notifications UI #385

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Conversation

AyaNady17
Copy link
Contributor

@AyaNady17 AyaNady17 commented Oct 27, 2024

Description

This PR enhances the Notifications UI to make it more visually appealing and intuitive. The update includes improved spacing, rounded borders, background colors, and icons for each notification type to create a more modern look similar to real app notifications. Mock data has been added to populate the list with diverse examples.

Changes:

  • Added card-like styling for each notification tile with rounded borders, padding, and shadow effects.
  • Adjusted spacing for better readability, especially between avatar and text.
  • Added icons for each notification type using a switch case, with color coding for quick identification.
  • Updated background color of notification tiles to enhance visibility.
  • Enhanced mock data to provide more variety in the notification list.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (does not change functionality, e.g., code style improvements, linting)
  • Documentation update

How Has This Been Tested?

UI was tested by manually running the application and checking that the notification tiles render correctly with the updated styles, icons, and spacing. Adjusted mock data was used to confirm visual consistency across different notification types.

Screenshots:
Screenshot_1730028432

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Maintainer Checklist

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tag the PR with the appropriate labels

@Aarush-Acharya Aarush-Acharya merged commit 26b3293 into dev Oct 29, 2024
@Aarush-Acharya Aarush-Acharya deleted the feature/update-notification-screen branch October 29, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants