-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: the discord icon redirects to discord page of aossie #403
feat: the discord icon redirects to discord page of aossie #403
Conversation
@Aarush-Acharya please review and merge this as well |
Hey @ARYPROGRAMMER, I saw this and I was in discussion with Chandan about the telegram icon as if telegram exists for AOSSIE or not I would want you to look if AOSSIE has a telegram if you are able to find it then great lead to the telegram of AOSSIE from that button just like you are doing for discord IF you cannot find it then refactor the UI in a way that removes the telegram button and the UI still looks good |
alright got it, currently at college would do it by 6 pm ist |
I wasn't able to find telegram channel for the org, instead of making the ui more blank and pale, I added X(twitter) page link with updated logo |
@Aarush-Acharya I hope this fixes the refracting problem and is a better alternative |
@Aarush-Acharya any updates on this? |
Please provide a screen recording after the fix. |
@AyaNady17 please find the video attached, this depicts the feature added: s1.mp4 |
please review and merge |
Good job @ARYPROGRAMMER |
Description
This PR improves the app by adding the feature to redirect user of AOSSIE discord page, they can discuss various topic there and learn more about this open source initiative
No Issue was raised, this PR directly implements the feature after manually going through the app
Type of change
How Has This Been Tested?
This was tested on a real Android 14.0.1 Redmi Note 10 Pro device. Below is the video of the implementation:
test_run.mp4
Checklist:
Maintainer Checklist