Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: the discord icon redirects to discord page of aossie #403

Merged
merged 3 commits into from
Dec 11, 2024

Conversation

ARYPROGRAMMER
Copy link

Description

This PR improves the app by adding the feature to redirect user of AOSSIE discord page, they can discuss various topic there and learn more about this open source initiative

No Issue was raised, this PR directly implements the feature after manually going through the app

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

This was tested on a real Android 14.0.1 Redmi Note 10 Pro device. Below is the video of the implementation:

test_run.mp4

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Maintainer Checklist

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tag the PR with the appropriate labels

@ARYPROGRAMMER
Copy link
Author

@Aarush-Acharya please review and merge this as well

@Aarush-Acharya
Copy link
Contributor

Hey @ARYPROGRAMMER, I saw this and I was in discussion with Chandan about the telegram icon as if telegram exists for AOSSIE or not

I would want you to look if AOSSIE has a telegram if you are able to find it then great lead to the telegram of AOSSIE from that button just like you are doing for discord

IF you cannot find it then refactor the UI in a way that removes the telegram button and the UI still looks good

@ARYPROGRAMMER
Copy link
Author

Hey @ARYPROGRAMMER, I saw this and I was in discussion with Chandan about the telegram icon as if telegram exists for AOSSIE or not

I would want you to look if AOSSIE has a telegram if you are able to find it then great lead to the telegram of AOSSIE from that button just like you are doing for discord

IF you cannot find it then refactor the UI in a way that removes the telegram button and the UI still looks good

alright got it, currently at college would do it by 6 pm ist

@ARYPROGRAMMER
Copy link
Author

Hey @ARYPROGRAMMER, I saw this and I was in discussion with Chandan about the telegram icon as if telegram exists for AOSSIE or not

I would want you to look if AOSSIE has a telegram if you are able to find it then great lead to the telegram of AOSSIE from that button just like you are doing for discord

IF you cannot find it then refactor the UI in a way that removes the telegram button and the UI still looks good

I wasn't able to find telegram channel for the org, instead of making the ui more blank and pale, I added X(twitter) page link with updated logo

@ARYPROGRAMMER
Copy link
Author

@Aarush-Acharya I hope this fixes the refracting problem and is a better alternative

@ARYPROGRAMMER
Copy link
Author

@Aarush-Acharya any updates on this?

@AyaNady17
Copy link
Member

@Aarush-Acharya any updates on this?

Please provide a screen recording after the fix.

@ARYPROGRAMMER
Copy link
Author

@AyaNady17 please find the video attached, this depicts the feature added:

s1.mp4

@ARYPROGRAMMER
Copy link
Author

@Aarush-Acharya any updates on this?

Please provide a screen recording after the fix.

please review and merge

@AyaNady17
Copy link
Member

Good job @ARYPROGRAMMER

@AyaNady17 AyaNady17 merged commit 134f128 into AOSSIE-Org:dev Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants