feat: Add per-user storage-class option

The 'per-user' storage type is an alternate storage-class name for the 'common' storage class.
In other words, it is an alias for the 'common' storage class and behaves in the same manner.

Part of eclipse-che/che#21405

Signed-off-by: Andrew Obuchowicz <aobuchow@redhat.com>

controllers/workspace/devworkspace_controller.go

@@ -685,7 +685,7 @@ func (r *DevWorkspaceReconciler) dwPVCHandler(obj client.Object) []reconcile.Req
 	var reconciles []reconcile.Request
 	for _, workspace := range dwList.Items {
 		storageType := workspace.Spec.Template.Attributes.GetString(constants.DevWorkspaceStorageTypeAttribute, nil)
-		if storageType == constants.CommonStorageClassType || storageType == "" {
+		if storageType == constants.CommonStorageClassType || storageType == constants.PerUserStorageClassType || storageType == "" {
 			reconciles = append(reconciles, reconcile.Request{
 				NamespacedName: types.NamespacedName{
 					Name:      workspace.GetName(),

pkg/constants/constants.go

@@ -64,9 +64,12 @@ const (
 
 	// Constants describing storage classes supported by the controller
 
-	// CommonStorageClassType defines the 'common' storage policy -- one PVC is provisioned per namespace and all devworkspace storage
-	// is mounted in it on subpaths according to devworkspace ID.
+	// CommonStorageClassType defines the 'common' storage policy, which is an alias of the 'per-user' storage policy, and operates in the same fashion as the 'per-user' storage policy.
+	// The 'common' storage policy exists only for legacy compatibility.
 	CommonStorageClassType = "common"
+	// PerUserStorageClassType defines the 'per-user' storage policy -- one PVC is provisioned per namespace and all devworkspace storage
+	// is mounted in it on subpaths according to devworkspace ID.
+	PerUserStorageClassType = "per-user"
 	// AsyncStorageClassType defines the 'asynchronous' storage policy. An rsync sidecar is added to devworkspaces that uses SSH to connect
 	// to a storage deployment that mounts a common PVC for the namespace.
 	AsyncStorageClassType = "async"

pkg/provision/storage/provisioner.go

@@ -54,6 +54,9 @@ func GetProvisioner(workspace *dw.DevWorkspace) (Provisioner, error) {
 		return &AsyncStorageProvisioner{}, nil
 	case constants.EphemeralStorageClassType:
 		return &EphemeralStorageProvisioner{}, nil
+	case constants.PerUserStorageClassType:
+		workspace.Spec.Template.Attributes.PutString(constants.DevWorkspaceStorageTypeAttribute, constants.CommonStorageClassType)
+		return &CommonStorageProvisioner{}, nil
 	default:
 		return nil, UnsupportedStorageStrategy
 	}

pkg/provision/storage/shared.go

@@ -252,7 +252,7 @@ func getSharedPVCWorkspaceCount(namespace string, api sync.ClusterAPI) (total in
 		}
 		storageClass := workspace.Spec.Template.Attributes.GetString(constants.DevWorkspaceStorageTypeAttribute, nil)
 		// Note, if the storageClass attribute isn't set (ie. storageClass == ""), then the storage class being used is "common"
-		if storageClass == constants.AsyncStorageClassType || storageClass == constants.CommonStorageClassType || storageClass == "" {
+		if storageClass == constants.AsyncStorageClassType || storageClass == constants.CommonStorageClassType || storageClass == constants.PerUserStorageClassType || storageClass == "" {
 			total++
 		}
 	}