Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip known errors or unsupported api in real-world api spec #178

Merged
merged 7 commits into from
Aug 15, 2021

Conversation

shenie
Copy link
Contributor

@shenie shenie commented Jul 21, 2021

I've skipped 3.1.0 yamls which is going to be supported only after #171

Then I added what I can see are errors with the api to known errors list.

fwiw the spec is also failing on v10.0.2 presumably because the swagger yaml's has changed since last tag (assuming that the build was green when last tag was made) but I'm just trying to get main green asap so that it can get another tag release... so that I can get the z-schema cve fix....

@shenie
Copy link
Contributor Author

shenie commented Jul 21, 2021

@philsturgeon pls review

@philsturgeon
Copy link
Member

If somebody can get the build to pas I’ll be happy to merge it. No time to dig into why it’s failing, still on a month like bike tour of Europe. Bad WiFi I’m the desert. I believe in you!

@shenie
Copy link
Contributor Author

shenie commented Aug 11, 2021

I've fixed the lint error. How do I trigger the build again? Because I'm seeing the following message at the bottom of my PR.

'''
1 workflow awaiting approval
First-time contributors need a maintainer to approve running workflows. Learn more.
'''

@philsturgeon
Copy link
Member

I booped it

@shenie
Copy link
Contributor Author

shenie commented Aug 11, 2021

I excluded another 3.1.0 yaml so the node 12 job should pass now.
The other failure is the browser job... but I can't tell what failed....

EDIT:

The closest thing I can see in the browser job that might've been the issue are following but I'm not sure where I am supposed to do that....

11 08 2021 19:05:01.030:ERROR [launcher]: No binary for Edge browser on your platform.
362
  Please, set "EDGE_BIN" env variable.
363
11 08 2021 19:05:01.412:ERROR [launcher]: No binary for Safari browser on your platform.
364
  Please, set "SAFARI_BIN" env variable.
365

@shenie
Copy link
Contributor Author

shenie commented Aug 11, 2021

And it looks like github actions that runs the build still require approval every time I push a fix...

@philsturgeon
Copy link
Member

@shenie sorry for this annoying github security feature, we've changed how tests run a little while ago and this is part of that. I'll be around my computer a bunch to click "Approve and Run" as much as needed. So far only two failing on ubuntu now!

@shenie
Copy link
Contributor Author

shenie commented Aug 14, 2021

Thanks.. working on it this morning.

@shenie
Copy link
Contributor Author

shenie commented Aug 14, 2021

Ok, pushed. npm run test:node passes on my laptop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants