Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert Heading component to separate level from className #20

Merged
merged 3 commits into from
May 16, 2019
Merged

Convert Heading component to separate level from className #20

merged 3 commits into from
May 16, 2019

Conversation

mattaho
Copy link
Contributor

@mattaho mattaho commented May 16, 2019

No description provided.

@mattaho mattaho requested a review from kimthompson May 16, 2019 19:55
mattaho
mattaho commented May 16, 2019
View reviewed changes
src/atoms/Heading/Heading.js Outdated Show resolved Hide resolved
@mattaho mattaho force-pushed the heading-levels-classes branch from c5ef6b7 to 0add360 Compare May 16, 2019 20:45
@mattaho mattaho force-pushed the heading-levels-classes branch from 0add360 to 293c4e6 Compare May 16, 2019 20:58
kimthompson
kimthompson approved these changes May 16, 2019
View reviewed changes
Copy link

@kimthompson kimthompson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks great to me!

@mattaho mattaho merged commit 4cb08a4 into master May 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kimthompson kimthompson kimthompson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattaho @kimthompson